Skip to content

Dualstack Network Support#549

Merged
Gerrit91 merged 81 commits intomasterfrom
dualstack-support
Feb 19, 2025
Merged

Dualstack Network Support#549
Gerrit91 merged 81 commits intomasterfrom
dualstack-support

Conversation

@majst01
Copy link
Contributor

@majst01 majst01 commented Jul 17, 2024

Closes #164

Actions Required

The ChildPrefixLength property was removed from the Partition Entity. Every TenantSupernetwork must now be configured with ChildPrefixLength accordingly.
This is done during startup in the database migration step and set to the same value as in the `Partition`.

It is required to add a defaultchildprefixlength property to the tenant super network in you configuration because otherwise the initial network creation will fail:
Sample:
  defaultchildprefixlength:
    IPv4: 22

Also ensure that all firewall-controllers are up-to-date in all firewalls before adding ipv6 prefixes to any of the exiting networks.

Depends on:

replaces #544

TODO:

  • add possibility to create machines in different networks like internet and tenant-network, but only from tenant-network IPs from both AF are acquired, but only ipv4 is possible from internet even if dualstack

@majst01 majst01 force-pushed the dualstack-support branch 4 times, most recently from 5919c8f to 0c53831 Compare July 23, 2024 07:47
@majst01 majst01 force-pushed the dualstack-support branch 7 times, most recently from d49d2c0 to b65c835 Compare July 25, 2024 09:50
@majst01 majst01 force-pushed the dualstack-support branch 3 times, most recently from 23a3d1e to 89096c0 Compare August 2, 2024 12:40
@majst01 majst01 force-pushed the dualstack-support branch 2 times, most recently from a3571a2 to d9667d3 Compare August 5, 2024 07:13
Copy link
Contributor

@vknabel vknabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from my side. If you address the comments from gerrit, this should be ready to go :)

afs = append(afs, af)
}
}
new.AddressFamilies = afs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO check if required to store AF in the db

return
}
if !slices.Contains(nw.AddressFamilies, af) {
r.sendError(request, response, httperrors.BadRequest(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if this error is really thrown

@Gerrit91 Gerrit91 merged commit de1f529 into master Feb 19, 2025
2 checks passed
@Gerrit91 Gerrit91 deleted the dualstack-support branch February 19, 2025 08:11
@Gerrit91 Gerrit91 mentioned this pull request Mar 3, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

☂️-Issue IPv6 Support

5 participants